You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/03 03:45:29 UTC
[GitHub] [tvm] masahi opened a new pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
masahi opened a new pull request #10459:
URL: https://github.com/apache/tvm/pull/10459
https://github.com/apache/tvm/pull/10439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lyken17 commented on pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
Lyken17 commented on pull request #10459:
URL: https://github.com/apache/tvm/pull/10459#issuecomment-1057645460
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged pull request #10459:
URL: https://github.com/apache/tvm/pull/10459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #10459:
URL: https://github.com/apache/tvm/pull/10459#discussion_r818341639
##########
File path: tests/python/relay/test_op_grad_level2.py
##########
@@ -281,5 +281,37 @@ def test_conv2d_backward_weight():
)
+def test_conv2d_backward_weight_infer_type():
+ # From https://github.com/apache/tvm/pull/10439
+ import tvm
+ from tvm import relay
Review comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] YuchenJin commented on a change in pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
YuchenJin commented on a change in pull request #10459:
URL: https://github.com/apache/tvm/pull/10459#discussion_r818343820
##########
File path: tests/python/relay/test_op_grad_level2.py
##########
@@ -281,5 +281,37 @@ def test_conv2d_backward_weight():
)
+def test_conv2d_backward_weight_infer_type():
+ # From https://github.com/apache/tvm/pull/10439
+ import tvm
+ from tvm import relay
Review comment:
lol, it happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lyken17 commented on pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
Lyken17 commented on pull request #10459:
URL: https://github.com/apache/tvm/pull/10459#issuecomment-1057639428
Thanks for the quick fix. How about also adding the type infer in python side?
https://github.com/apache/tvm/blob/8f6fa8f2c41406cb54d01647ba8731e4ceb8f4ab/python/tvm/relay/op/_tensor_grad.py#L417-L440
```
if attrs.out_dtype == "":
out_dtype = data.checked_type.dtype
backward_data = _nn.conv2d_transpose(
grad,
weight,
strides=attrs.strides,
padding=attrs.padding,
dilation=attrs.dilation,
groups=attrs.groups,
output_padding=output_padding,
out_dtype=out_dtype,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] YuchenJin commented on a change in pull request #10459: [Relay] Fix output dtype for conv2d wgrad when the original one is void
Posted by GitBox <gi...@apache.org>.
YuchenJin commented on a change in pull request #10459:
URL: https://github.com/apache/tvm/pull/10459#discussion_r818325048
##########
File path: tests/python/relay/test_op_grad_level2.py
##########
@@ -281,5 +281,37 @@ def test_conv2d_backward_weight():
)
+def test_conv2d_backward_weight_infer_type():
+ # From https://github.com/apache/tvm/pull/10439
+ import tvm
+ from tvm import relay
Review comment:
Are they already imported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org