[GitHub] dclim commented on a change in pull request #6563: add missing license headers, in particular to MD files; clean up RAT …

[GitBox <gi...@apache.org>]

dclim commented on a change in pull request #6563: add missing license headers, in particular to MD files; clean up RAT …
URL: https://github.com/apache/incubator-druid/pull/6563#discussion_r229864901
 
 

 ##########
 File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
 ##########
 @@ -1,5 +1,20 @@
 grammar Expr;
 
+// Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   @jihoonson putting it at the beginning would be better. I wasn't sure if the `grammar` keyword needed to be on the first line (like <?xml> needing to be on the first line of the file) and the example I saw had comments after `grammar` but I found another example with a proper header on line 1 (https://github.com/antlr/grammars-v4/blob/master/cpp/CPP14.g4). Will change, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org