[GitHub] [metron] merrimanr commented on a change in pull request #1400: METRON-2106: Escalation topic setting in Ambari has no effect

[GitBox <gi...@apache.org>]

merrimanr commented on a change in pull request #1400: METRON-2106: Escalation topic setting in Ambari has no effect
URL: https://github.com/apache/metron/pull/1400#discussion_r282551275
 
 

 ##########
 File path: metron-interface/metron-rest/src/main/scripts/metron-rest.sh
 ##########
 @@ -83,7 +83,7 @@ echo "METRON_SPRING_PROFILES_ACTIVE=${METRON_SPRING_PROFILES_ACTIVE}"
 
 # the vagrant Spring profile provides configuration values, otherwise configuration is provided by rest_application.yml
 if [[ !(${METRON_SPRING_PROFILES_ACTIVE} == *"vagrant"*) ]]; then
-    METRON_CONFIG_LOCATION=" --spring.config.location=$METRON_HOME/config/rest_application.yml,classpath:/application.yml"
 
 Review comment:
   Using `--spring.config.location` replaces the default locations.  This is why `classpath:/application.yml` was originally included even though it matches the default locations.  Using `--spring.config.additional-location` adds to the list of configs instead of replacing the default locations so having `classpath:/application.yml` in the list is no longer necessary.  Doing it this way enforces that anything added on top with `--spring.config.additional-location` will take priority over the default.  I think this is the correct way to do it because you don't have to worry about ordering them correctly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services