You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/22 18:58:11 UTC

[GitHub] srkukarni commented on a change in pull request #2813: Removed Validation Annotations and do manual Validation

srkukarni commented on a change in pull request #2813: Removed Validation Annotations and do manual Validation
URL: https://github.com/apache/pulsar/pull/2813#discussion_r226995410
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutor.java
 ##########
 @@ -100,7 +99,6 @@ private WindowConfig getWindowConfigs(Context context) {
 
 
         WindowUtils.inferDefaultConfigs(windowConfig);
-        ValidatorImpls.WindowConfigValidator.validateWindowConfig(windowConfig);
 
 Review comment:
   This is not the right place to do validation. All of the validation of windowConfig happens when we are doing FunctionConfigValidation. The executor should just be in charge of executing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services