You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Stas Bekman <st...@stason.org> on 2004/08/12 09:12:38 UTC

1.0: socket_bucket_read() fails to handle blocking flags

socket_bucket_read() still fails to handle the blocking flag. Are you OK 
releasing APR 1.0 with this bug?

For details please see:
http://marc.theaimsgroup.com/?t=108401828500002&r=1&w=2

The latest solution proposal was from Joe:

 >> On Mon, 17 May 2004, Joe Orton wrote:
 >>
 >>
 >>> I'd hoped some friendly buckets guru would step in here :) I guess if
 >>> it's correct to solve this at bucket-level, the solution is to make
 >>> socket_bucket_read() check whether the socket is non-blocking on each
 >>> call, and temporarily set the timeout to -1 if it is...

but it has died there :(

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: 1.0: socket_bucket_read() fails to handle blocking flags

Posted by Stas Bekman <st...@stason.org>.
Joe Orton wrote:
> On Thu, Aug 12, 2004 at 12:12:38AM -0700, Stas Bekman wrote:
> 
>>socket_bucket_read() still fails to handle the blocking flag. Are you OK 
>>releasing APR 1.0 with this bug?
>>
>>For details please see:
>>http://marc.theaimsgroup.com/?t=108401828500002&r=1&w=2
> 
> 
> I took a further look at this a while back, and it looked like the fix I
> suggested was not portable: setting a timeout on a non-blocking socket
> has no effect on Win32.
> 
> http://marc.theaimsgroup.com/?l=apr-dev&m=106561692726135&w=2
> 
> so I'm out of ideas.

:(

>>The latest solution proposal was from Joe:
>>
>>
>>>>On Mon, 17 May 2004, Joe Orton wrote:
>>>>
>>>>
>>>>
>>>>>I'd hoped some friendly buckets guru would step in here :) I guess if
>>>>>it's correct to solve this at bucket-level, the solution is to make
>>>>>socket_bucket_read() check whether the socket is non-blocking on each
>>>>>call, and temporarily set the timeout to -1 if it is...
>>
>>but it has died there :(

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: 1.0: socket_bucket_read() fails to handle blocking flags

Posted by Joe Orton <jo...@redhat.com>.
On Thu, Aug 12, 2004 at 12:12:38AM -0700, Stas Bekman wrote:
> socket_bucket_read() still fails to handle the blocking flag. Are you OK 
> releasing APR 1.0 with this bug?
> 
> For details please see:
> http://marc.theaimsgroup.com/?t=108401828500002&r=1&w=2

I took a further look at this a while back, and it looked like the fix I
suggested was not portable: setting a timeout on a non-blocking socket
has no effect on Win32.

http://marc.theaimsgroup.com/?l=apr-dev&m=106561692726135&w=2

so I'm out of ideas.

> The latest solution proposal was from Joe:
> 
> >> On Mon, 17 May 2004, Joe Orton wrote:
> >>
> >>
> >>> I'd hoped some friendly buckets guru would step in here :) I guess if
> >>> it's correct to solve this at bucket-level, the solution is to make
> >>> socket_bucket_read() check whether the socket is non-blocking on each
> >>> call, and temporarily set the timeout to -1 if it is...
> 
> but it has died there :(
> 
> -- 
> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com