You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2020/02/24 18:06:13 UTC
[GitHub] [geode] jinmeiliao opened pull request #4727: GEODE-7421:
deploy using management rest api
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #4727:
GEODE-7421: deploy using management rest api
Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
You can chain assertions if you like:
```
assertThat(throwable)
.isInstanceOf(IllegalArgumentException.class);
.hasMessageContaining("File does not contain valid JAR content:");
```
Also note that AssertJ's assertions do a null check, so you don't need `isNotNull()` unless it helps to clarify the test.
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] lgtm-com[bot] commented on issue #4727: GEODE-7421:
deploy using management rest api
Posted by lg...@gitbox.apache.org.
This pull request **introduces 1 alert** and **fixes 1** when merging a648fc43f29998c69b22cdd3bf6dd12da8345faf into 56f51e8724b1644a2af6b1a8998f131c544725de - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-d1aa0929e0a6bc0a7b2c0d76e5020d49bbae2e22)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 1 for Dereferenced variable may be null
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #4727:
GEODE-7421: deploy using management rest api
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
put the try/catch around the close call (ie: inside the new "if")
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] lgtm-com[bot] commented on issue #4727: GEODE-7421:
deploy using management rest api
Posted by lg...@gitbox.apache.org.
This pull request **introduces 1 alert** and **fixes 1** when merging f84e5aecdb31438bda264041a019fa0a7777b654 into aff15491df07ae067a03edcf3a1e797495ddbe02 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-8a0d1f85b0ca8afda6941d04f487fcaff3a25ad8)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 1 for Dereferenced variable may be null
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #4727:
GEODE-7421: deploy using management rest api
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
as commented before.
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #4727:
GEODE-7421: deploy using management rest api
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
it depends on each configuration manager's implementation. I don't think we can dictate on what kind of exception it can throw. I added this signature here so that the handling of the exception falls on the caller, not the implementer.
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #4727: GEODE-7421:
deploy using management rest api
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
closing this for PR checks.
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao closed pull request #4727: GEODE-7421:
deploy using management rest api
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/4727 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org