You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/26 18:15:35 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4902: esp32xx_rtc.c: misc. fixes.

gustavonihei commented on a change in pull request #4902:
URL: https://github.com/apache/incubator-nuttx/pull/4902#discussion_r757653386



##########
File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c
##########
@@ -2464,8 +2467,8 @@ int up_rtc_gettime(struct timespec *tp)
     }
   else
     {
-      time_us = = esp32c3_rtc_get_time_us() +
-                    esp32c3_rtc_get_boot_time();
+      time_us = esp32c3_rtc_get_time_us() +
+                esp32c3_rtc_get_boot_time();

Review comment:
       ```suggestion
         time_us = esp32c3_rtc_get_time_us() + esp32c3_rtc_get_boot_time();
   ```
   nit: These lines fit in a single one, how about merging them?

##########
File path: arch/xtensa/src/esp32/esp32_rtc.c
##########
@@ -2066,8 +2069,8 @@ int up_rtc_gettime(struct timespec *tp)
     }
   else
     {
-      time_us = = esp32_rtc_get_time_us() +
-                    esp32_rtc_get_boot_time();
+      time_us = esp32_rtc_get_time_us() +
+                esp32_rtc_get_boot_time();

Review comment:
       ```suggestion
         time_us = esp32_rtc_get_time_us() + esp32_rtc_get_boot_time();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org