You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by ah...@apache.org on 2023/02/01 06:21:15 UTC
[causeway] branch master updated: CAUSEWAY-2297: rename TODO markers ISIS -> CAUSEWAY
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git
The following commit(s) were added to refs/heads/master by this push:
new 0b2aed59e2 CAUSEWAY-2297: rename TODO markers ISIS -> CAUSEWAY
0b2aed59e2 is described below
commit 0b2aed59e207e6ca29bcdf6c3eb1461e648dc92d
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Feb 1 07:21:10 2023 +0100
CAUSEWAY-2297: rename TODO markers ISIS -> CAUSEWAY
---
.../org/apache/causeway/commons/internal/reflection/_ClassCache.java | 2 +-
.../core/metamodel/object/_ManagedObjectEntityBookmarked.java | 2 +-
.../core/runtimeservices/session/InteractionServiceDefault.java | 2 +-
.../DomainObjectLayout/xxxUiEvent/DomainObjectLayoutXxxUiEventVm.java | 2 +-
.../causeway/extensions/docgen/topics/welcome/WelcomeHelpPage.java | 2 +-
.../persistence/jpa/applib/integration/CausewayEntityListener.java | 2 +-
.../jpa/eclipselink/CausewayModulePersistenceJpaEclipselink.java | 2 +-
.../components/widgets/fileinput/FileUploadFieldWithNestingFix.java | 4 ++--
.../java/org/apache/causeway/viewer/wicket/ui/util/WktTooltips.java | 2 +-
9 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/commons/src/main/java/org/apache/causeway/commons/internal/reflection/_ClassCache.java b/commons/src/main/java/org/apache/causeway/commons/internal/reflection/_ClassCache.java
index 8f12495698..dda6a7c8bb 100644
--- a/commons/src/main/java/org/apache/causeway/commons/internal/reflection/_ClassCache.java
+++ b/commons/src/main/java/org/apache/causeway/commons/internal/reflection/_ClassCache.java
@@ -243,7 +243,7 @@ public final class _ClassCache implements AutoCloseable {
val declaredFields = type.getDeclaredFields();
val declaredMethods = //type.getDeclaredMethods(); ... cannot detect non overridden inherited methods
Can.ofStream(_Reflect.streamAllMethods(type, true));
- val publicMethods = type.getMethods(); //XXX[ISIS-3327] order of methods returned might differ among JVM instances
+ val publicMethods = type.getMethods(); //XXX[CAUSEWAY-3327] order of methods returned might differ among JVM instances
val model = new ClassModel(
Can.ofArray(declaredFields),
diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/object/_ManagedObjectEntityBookmarked.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/object/_ManagedObjectEntityBookmarked.java
index 888c4b06bd..50960cdc70 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/object/_ManagedObjectEntityBookmarked.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/object/_ManagedObjectEntityBookmarked.java
@@ -89,7 +89,7 @@ implements _Refetchable {
return pojo; // is attached
}
- //[ISIS-3265] this getPojo() call might originate from a CausewayEntityListener.onPostLoad event,
+ //[CAUSEWAY-3265] this getPojo() call might originate from a CausewayEntityListener.onPostLoad event,
// in which case potentially runs into a nested loop resulting in a stack overflow;
if(refetching) {
throw _Exceptions.unrecoverable("framework bug: nested call to getPojo() while already refetching");
diff --git a/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/session/InteractionServiceDefault.java b/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/session/InteractionServiceDefault.java
index 7a75891927..f7bcfafcec 100644
--- a/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/session/InteractionServiceDefault.java
+++ b/core/runtimeservices/src/main/java/org/apache/causeway/core/runtimeservices/session/InteractionServiceDefault.java
@@ -380,7 +380,7 @@ implements
try {
transactionServiceProvider.get().flushTransaction();
} catch (RuntimeException e) {
- //[ISIS-3262] if flush fails rethrow later, when interaction was closed ...
+ //[CAUSEWAY-3262] if flush fails rethrow later, when interaction was closed ...
flushException = e;
}
diff --git a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObjectLayout/xxxUiEvent/DomainObjectLayoutXxxUiEventVm.java b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObjectLayout/xxxUiEvent/DomainObjectLayoutXxxUiEventVm.java
index 42b1874451..57f9ab436e 100644
--- a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObjectLayout/xxxUiEvent/DomainObjectLayoutXxxUiEventVm.java
+++ b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/DomainObjectLayout/xxxUiEvent/DomainObjectLayoutXxxUiEventVm.java
@@ -48,7 +48,7 @@ public class DomainObjectLayoutXxxUiEventVm implements HasAsciiDocDescription {
return "DomainObjectLayout#xxxUiEvent";
}
- //TODO[ISIS-3309]
+ //TODO[CAUSEWAY-3309]
@Property(optionality = Optionality.OPTIONAL)
@XmlElement(required = false)
@Getter @Setter
diff --git a/extensions/core/docgen/src/main/java/org/apache/causeway/extensions/docgen/topics/welcome/WelcomeHelpPage.java b/extensions/core/docgen/src/main/java/org/apache/causeway/extensions/docgen/topics/welcome/WelcomeHelpPage.java
index db9c52a8e6..dcfff3693a 100644
--- a/extensions/core/docgen/src/main/java/org/apache/causeway/extensions/docgen/topics/welcome/WelcomeHelpPage.java
+++ b/extensions/core/docgen/src/main/java/org/apache/causeway/extensions/docgen/topics/welcome/WelcomeHelpPage.java
@@ -208,7 +208,7 @@ public class WelcomeHelpPage implements HelpPage {
"fa fa-fw fa-list",
member.getCanonicalFriendlyName(),
description != null ? description : ""));
- // FIXME[ISIS-2883] also visit associated actions
+ // FIXME[CAUSEWAY-2883] also visit associated actions
// ... collection.streamAssociatedActions()
html.append("<ul>");
member.streamAssociatedActions().forEach(action -> {
diff --git a/persistence/jpa/applib/src/main/java/org/apache/causeway/persistence/jpa/applib/integration/CausewayEntityListener.java b/persistence/jpa/applib/src/main/java/org/apache/causeway/persistence/jpa/applib/integration/CausewayEntityListener.java
index d21bb867af..698afe672e 100644
--- a/persistence/jpa/applib/src/main/java/org/apache/causeway/persistence/jpa/applib/integration/CausewayEntityListener.java
+++ b/persistence/jpa/applib/src/main/java/org/apache/causeway/persistence/jpa/applib/integration/CausewayEntityListener.java
@@ -79,7 +79,7 @@ public class CausewayEntityListener {
val entityState = entity.getEntityState();
if(!entityState.isAttached()) {
- // [ISIS-3265] seeing this with JPA
+ // [CAUSEWAY-3265] seeing this with JPA
// if we don't exit here will cause a nested loop repeatedly trying to refetch the pojo
log.error("onPostLoad event while pojo not attached ({}); ignoring the event",
entityState.name());
diff --git a/persistence/jpa/eclipselink/src/main/java/org/apache/causeway/persistence/jpa/eclipselink/CausewayModulePersistenceJpaEclipselink.java b/persistence/jpa/eclipselink/src/main/java/org/apache/causeway/persistence/jpa/eclipselink/CausewayModulePersistenceJpaEclipselink.java
index fc51d49439..f9397ff3ab 100644
--- a/persistence/jpa/eclipselink/src/main/java/org/apache/causeway/persistence/jpa/eclipselink/CausewayModulePersistenceJpaEclipselink.java
+++ b/persistence/jpa/eclipselink/src/main/java/org/apache/causeway/persistence/jpa/eclipselink/CausewayModulePersistenceJpaEclipselink.java
@@ -198,7 +198,7 @@ public class CausewayModulePersistenceJpaEclipselink extends JpaBaseConfiguratio
"JPA operation: " + nextEx.getMessage(),
extractSqlStringFromException(nextEx),
nextEx))
- .filter(_NullSafe::isPresent) //ISIS-3282
+ .filter(_NullSafe::isPresent) //CAUSEWAY-3282
.findFirst()
.orElse(null);
diff --git a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/widgets/fileinput/FileUploadFieldWithNestingFix.java b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/widgets/fileinput/FileUploadFieldWithNestingFix.java
index 7d8e4ce77c..c2997924df 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/widgets/fileinput/FileUploadFieldWithNestingFix.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/widgets/fileinput/FileUploadFieldWithNestingFix.java
@@ -55,7 +55,7 @@ public class FileUploadFieldWithNestingFix extends BootstrapFileInputField {
@Override
public boolean isRequired() {
- //FIXME[ISIS-3203]
+ //FIXME[CAUSEWAY-3203]
return false; // nothing else worked yet
}
@@ -64,7 +64,7 @@ public class FileUploadFieldWithNestingFix extends BootstrapFileInputField {
// public void convertInput() {
// super.convertInput(); // keep side-effects
// if(!isRequired()) {return;}
-// /*[ISIS-3203]: in the context of mandatory property or action parameter negotiation,
+// /*[CAUSEWAY-3203]: in the context of mandatory property or action parameter negotiation,
// * we need to set the converted input to something other than null, even an empty list will do
// */
// if(isConvertedInputNull()
diff --git a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/util/WktTooltips.java b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/util/WktTooltips.java
index a4fbc1a710..2d21e1116e 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/util/WktTooltips.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/util/WktTooltips.java
@@ -61,7 +61,7 @@ public class WktTooltips {
if(target instanceof ActionLink) {
val actionLink = (ActionLink)target;
if(!actionLink.getActionModel().hasParameters()) {
- //XXX[ISIS-3051] adding a tooltip to an ActionLink will break any ConfirmationBehavior,
+ //XXX[CAUSEWAY-3051] adding a tooltip to an ActionLink will break any ConfirmationBehavior,
//that's also applied to the ActionLink.
throw _Exceptions.illegalArgument(
"Adding a tooltip to an ActionLink will break any ConfirmationBehavior, "