You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/10/12 00:10:40 UTC
Review Request 26614: More simplifications of Docker container
launching.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26614/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 26614: More simplifications of Docker container
launching.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 11, 2014, 10:33 p.m., Timothy Chen wrote:
> >
Okay, I updated this in a new review: https://reviews.apache.org/r/26620
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/#review56306
-----------------------------------------------------------
On Oct. 11, 2014, 10:10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26614/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26614/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 26614: More simplifications of Docker container
launching.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/#review56306
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26614/#comment96619>
We add the TaskInfo's command env variables in the docker abstraction, so it is correct.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26614/#comment96620>
Just realized this is redundant, as we're adding the command Info's env variables in the docker abstraction too.
- Timothy Chen
On Oct. 11, 2014, 10:10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26614/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26614/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 26614: More simplifications of Docker container
launching.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/#review56370
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 11, 2014, 10:10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26614/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26614/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>