You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/06/30 18:44:43 UTC
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404559#comment-13404559 ]
Hadoop QA commented on HBASE-6296:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534114/java_hbase-6296-v0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2302//console
This message is automatically generated.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira