[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1439: add iceberg spark batch sink

[GitBox <gi...@apache.org>]

wuchunfu commented on a change in pull request #1439:
URL: https://github.com/apache/incubator-seatunnel/pull/1439#discussion_r822215517



##########
File path: docs/en/spark/configuration/sink-plugins/Iceberg.md
##########
@@ -0,0 +1,62 @@
+# Iceberg
+
+> Sink plugin: Iceberg [Spark]
+
+## Description
+
+Write data to Iceberg.
+
+## Options
+
+| name           | type   | required | default value |
+| -------------- | ------ | -------- | ------------- |
+| [path](#path)  | string | yes      | -             |
+| [saveMode](#saveMode) | string | yes | -             |
+| [target-file-size-bytes](#target-file-size-bytes) | long | no      | -   |
+| [check-nullability](#check-nullability) | bool | no| - |
+| [snapshot-property.custom-key](#snapshot-property.custom-key) | string | no| - |
+| [fanout-enabled](#fanout-enabled) | bool | no| - |
+| [check-ordering](#check-ordering) | bool | no| - |
+
+
+Refer to [iceberg write options](https://iceberg.apache.org/docs/latest/spark-configuration/) for more configurations.
+
+### path
+
+Iceberg table location.
+
+### saveMode
+

Review comment:
       @ououtt `saveMode` I guess it's better to have a default value

##########
File path: docs/en/spark/configuration/sink-plugins/Iceberg.md
##########
@@ -0,0 +1,62 @@
+# Iceberg
+
+> Sink plugin: Iceberg [Spark]
+
+## Description
+
+Write data to Iceberg.
+
+## Options
+
+| name           | type   | required | default value |
+| -------------- | ------ | -------- | ------------- |
+| [path](#path)  | string | yes      | -             |
+| [saveMode](#saveMode) | string | yes | -             |
+| [target-file-size-bytes](#target-file-size-bytes) | long | no      | -   |
+| [check-nullability](#check-nullability) | bool | no| - |
+| [snapshot-property.custom-key](#snapshot-property.custom-key) | string | no| - |
+| [fanout-enabled](#fanout-enabled) | bool | no| - |
+| [check-ordering](#check-ordering) | bool | no| - |
+
+
+Refer to [iceberg write options](https://iceberg.apache.org/docs/latest/spark-configuration/) for more configurations.
+
+### path
+
+Iceberg table location.
+
+### saveMode
+

Review comment:
       Is `saveMode` only these two? I think you can write a link that looks for `saveMode` after




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org