You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/07/31 09:25:35 UTC

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #188: LIVY-615: Set context path using property SERVER_BASE_PATH.

jerryshao commented on a change in pull request #188: LIVY-615: Set context path using property SERVER_BASE_PATH.
URL: https://github.com/apache/incubator-livy/pull/188#discussion_r309121857
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/WebServer.scala
 ##########
 @@ -81,7 +81,10 @@ class WebServer(livyConf: LivyConf, var host: String, var port: Int) extends Log
 
   val context = new ServletContextHandler()
 
-  context.setContextPath("/")
+  private val contextPath = "/" + livyConf.get(LivyConf.SERVER_BASE_PATH).stripPrefix("/")
 
 Review comment:
   Seems like this will also change the path of REST API, am I right? IIUC the configuration is only used for UI, so the fix should only be in UI side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services