You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/12 08:50:46 UTC
[GitHub] [flink] zeliu opened a new pull request, #19706: modify the number of parameters
zeliu opened a new pull request, #19706:
URL: https://github.com/apache/flink/pull/19706
The number of arguments is 4, not 5
--input-topic <topic>
--output-topic <topic>
--bootstrap.servers <kafka brokers>
--group.id <some id>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19706:
URL: https://github.com/apache/flink/pull/19706#issuecomment-1124735566
@zeliu Thanks for opening the ticket and the PR, but this seems incorrect. The number of arguments is indeed 4, but the code is checking if the number of provided arguments is less than 5. Since 4 is less than 5, the code is indeed working as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zeliu commented on pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
zeliu commented on PR #19706:
URL: https://github.com/apache/flink/pull/19706#issuecomment-1124823145
@MartijnVisser Thanks for your reply, but if the number of arguments less than 5, it will throw exceptions.
In org.apache.flink.streaming.kafka.test.KafkaExample ,I provided 4 parameters, and it will report an #error.
```
if (parameterTool.getNumberOfParameters() < 5) {
System.out.println(
"Missing parameters!\n"
+ "Usage: Kafka --input-topic <topic> --output-topic <topic> "
+ "--bootstrap.servers <kafka brokers> "
+ "--group.id <some id>");
throw new Exception(
"Missing parameters!\n"
+ "Usage: Kafka --input-topic <topic> --output-topic <topic> "
+ "--bootstrap.servers <kafka brokers> "
+ "--group.id <some id>");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zeliu commented on pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
zeliu commented on PR #19706:
URL: https://github.com/apache/flink/pull/19706#issuecomment-1124863654
@MartijnVisser
**I can only provide a screenshot of IDE. I provided 4 parameters, but it reported an error**
<img width="1549" alt="image" src="https://user-images.githubusercontent.com/10296199/168058362-ecf3ac21-6953-487c-b230-724ec6aa8f22.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19706:
URL: https://github.com/apache/flink/pull/19706#issuecomment-1124837533
> In org.apache.flink.streaming.kafka.test.KafkaExample ,I provided 4 parameters
Please explain exactly how you've done this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19706:
URL: https://github.com/apache/flink/pull/19706#issuecomment-1124709784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd53f3d24d88de2aa708d3a31ea729437d700b7e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd53f3d24d88de2aa708d3a31ea729437d700b7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd53f3d24d88de2aa708d3a31ea729437d700b7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser closed pull request #19706: modify the number of parameters
Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #19706: modify the number of parameters
URL: https://github.com/apache/flink/pull/19706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org