You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 12:57:17 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3749: remove `type coercion` for physical ScalarFunction

alamb commented on code in PR #3749:
URL: https://github.com/apache/arrow-datafusion/pull/3749#discussion_r992291451


##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -2872,4 +2874,17 @@ mod tests {
 
         Ok(())
     }
+
+    // Helper function
+    // The type coercion will be done in the logical phase, should do the type coercion for the test

Review Comment:
   👍 
   
   BTW this is basically what I need to do in IOx / why I made https://github.com/apache/arrow-datafusion/issues/3708



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org