You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2019/12/05 14:49:58 UTC

[GitHub] [submarine] jiwq commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.

jiwq commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r353794124
 
 

 ##########
 File path: submarine-client/src/main/java/org/apache/submarine/client/cli/param/Localization.java
 ##########
 @@ -108,24 +108,27 @@ public String getRemoteUri() {
     return remoteUri;
   }
 
-  public void setRemoteUri(String rUti) {
+  public Localization setRemoteUri(String rUti) {
     this.remoteUri = rUti;
+    return this;
 
 Review comment:
   why change this method's return type?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org