You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/12/08 00:48:02 UTC
[PR] Make .splitWhen explicit with SubstreamCancelStrategy.drain [incubator-pekko-http]
mdedetrich opened a new pull request, #371:
URL: https://github.com/apache/incubator-pekko-http/pull/371
The context of this change is https://github.com/apache/incubator-pekko/pull/252. I want to try and get that PR over the finish line for Pekko 1.1.x and while that PR is not a binary breaking change it is a behaviour breaking change.
What this PR does is it makes any usage of `splitWhen` explicitly use `SubstreamCancelStrategy.drain` (which is the current default) so that if someone uses pekko-http with a future release of pekko 1.1.0 there won't be any behaviour change. Note that I am not entirely sure if this change makes sense or even if its necessary i.e. it may be the case that whatever `SubstreamCancelStrategy` you use it doesn't matter because the various `SubFlow`'s cannot error or it could also be that we really should be explicit about which `SubstreamCancelStrategy` to use for correctness reasons (i.e. if hypothetically an error in a `SubFlow` can occur then it should always be either `SubstreamCancelStrategy.drain` or `SubstreamCancelStrategy.propagate`)
@jrudolph @raboof Pinging you here since you have most of the domain knowledge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make .splitWhen explicit with SubstreamCancelStrategy.drain [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed pull request #371: Make .splitWhen explicit with SubstreamCancelStrategy.drain
URL: https://github.com/apache/incubator-pekko-http/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Make .splitWhen explicit with SubstreamCancelStrategy.drain [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #371:
URL: https://github.com/apache/incubator-pekko-http/pull/371#issuecomment-1870829637
Im going to close this since the premise is premature, should tackle each of the cases individually if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org