You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:07:49 UTC

[GitHub] [flink] liuzhuang2017 opened a new pull request, #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

liuzhuang2017 opened a new pull request, #19461:
URL: https://github.com/apache/flink/pull/19461

   
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Translate "Concepts -> Glossary" page into Chinese.
   
   ## Brief change log
   
   Translate "Concepts -> Glossary" page into Chinese.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuzhuang2017 commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1101060771

   Thanks for your reply, closed this pr for personal reasons, but I have resubmitted a pr (https://github.com/apache/flink/pull/19493).
   ________________________________
   发件人: Yun Tang ***@***.***>
   发送时间: 2022年4月18日 11:15
   收件人: apache/flink ***@***.***>
   抄送: liuzhuang2017 ***@***.***>; Mention ***@***.***>
   主题: Re: [apache/flink] [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese (PR #19461)
   
   
   @liuzhuang2017<https://github.com/liuzhuang2017> Why closed this PR?
   
   ―
   Reply to this email directly, view it on GitHub<https://github.com/apache/flink/pull/19461#issuecomment-1101051761>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWVWVLCFS5JUK73AE3AZYUDVFTHWJANCNFSM5TLFEZFQ>.
   You are receiving this because you were mentioned.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1101051761

   @liuzhuang2017 Why closed this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuzhuang2017 commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1099163124

   @Myasuka ,Thanks for your reply, I am modifying this pr according to your suggestion.  Can you help me rewiew this pr if you have free time? Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1098242818

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e393732819bd954762ded3168a37a375ab6a79",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c9e393732819bd954762ded3168a37a375ab6a79",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c9e393732819bd954762ded3168a37a375ab6a79 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1098662430

   @liuzhuang2017 First of all, why not filling up the description of this PR? You still left three parts unmodified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuzhuang2017 commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1101086623

   @Myasuka ,Thank you for your reply, I'll pay attention to it later, I'm really sorry about that. Can you help me review the new PR（https://github.com/apache/flink/pull/19493） if you have time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuzhuang2017 commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1098587752

   @Myasuka ,Sorry to bother you, can you help me rewiew this pr if you have free time? Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1101067194

   @liuzhuang2017 If you just want to switch the account who made the commits. You can force push your remote branch with your wanted author information. It would be a waste of energy when closing half-reviewd PR with opening another as the newer one would also lost previous discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuzhuang2017 commented on pull request #19461: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese

Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19461:
URL: https://github.com/apache/flink/pull/19461#issuecomment-1101061284

   @Myasuka ，Thanks for your reply, closed this pr for personal reasons, but I have resubmitted a pr ([#19493](https://github.com/apache/flink/pull/19493)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org