You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by zm...@apache.org on 2016/08/10 17:53:55 UTC

aurora git commit: Remove unnecessary guice container parameters.

Repository: aurora
Updated Branches:
  refs/heads/master 581262ccf -> c465fb1e2


Remove unnecessary guice container parameters.

I noticed these configuration parameters have no effect. Both the API and JAX-RS
endpoints like /vars return gipped content.

Testing Done:
$ curl -I -X GET http://192.168.33.7:8081/vars -H 'Accept-Encoding: gzip, deflate'
HTTP/1.1 200 OK
Date: Mon, 08 Aug 2016 15:18:12 GMT
Content-Type: text/plain
Vary: Accept-Encoding, User-Agent
Content-Encoding: gzip
Transfer-Encoding: chunked
Server: Jetty(9.3.6.v20151106)

Reviewed at https://reviews.apache.org/r/50931/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/c465fb1e
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/c465fb1e
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/c465fb1e

Branch: refs/heads/master
Commit: c465fb1e2ccabf19f6bf06737a333a3a1e7a1984
Parents: 581262c
Author: Zameer Manji <zm...@apache.org>
Authored: Wed Aug 10 10:53:47 2016 -0700
Committer: Zameer Manji <zm...@apache.org>
Committed: Wed Aug 10 10:53:47 2016 -0700

----------------------------------------------------------------------
 .../org/apache/aurora/scheduler/http/JettyServerModule.java   | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/c465fb1e/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
index 12185ec..7bf8185 100644
--- a/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
+++ b/src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
@@ -51,7 +51,6 @@ import com.google.inject.name.Names;
 import com.google.inject.servlet.GuiceFilter;
 import com.google.inject.servlet.GuiceServletContextListener;
 import com.google.inject.util.Modules;
-import com.sun.jersey.api.container.filter.GZIPContentEncodingFilter;
 import com.sun.jersey.guice.JerseyServletModule;
 import com.sun.jersey.guice.spi.container.servlet.GuiceContainer;
 
@@ -88,8 +87,6 @@ import org.slf4j.LoggerFactory;
 
 import static java.util.Objects.requireNonNull;
 
-import static com.sun.jersey.api.core.ResourceConfig.PROPERTY_CONTAINER_REQUEST_FILTERS;
-import static com.sun.jersey.api.core.ResourceConfig.PROPERTY_CONTAINER_RESPONSE_FILTERS;
 import static com.sun.jersey.api.json.JSONConfiguration.FEATURE_POJO_MAPPING;
 
 /**
@@ -120,9 +117,7 @@ public class JettyServerModule extends AbstractModule {
   protected static final Arg<String> LISTEN_IP = Arg.create();
 
   public static final Map<String, String> GUICE_CONTAINER_PARAMS = ImmutableMap.of(
-      FEATURE_POJO_MAPPING, Boolean.TRUE.toString(),
-      PROPERTY_CONTAINER_REQUEST_FILTERS, GZIPContentEncodingFilter.class.getName(),
-      PROPERTY_CONTAINER_RESPONSE_FILTERS, GZIPContentEncodingFilter.class.getName());
+      FEATURE_POJO_MAPPING, Boolean.TRUE.toString());
 
   private static final String STATIC_ASSETS_ROOT = Resource
       .newClassPathResource("scheduler/assets/index.html")