You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Suresh Balineni <sb...@juniper.net> on 2014/01/29 19:56:58 UTC
Review Request 17506: mvn clean - test logs- contrail -cleanps up only
target, dist directories;
testclient.log file should be generated inside target directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17506/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
mvn clean - cleanps up only target, dist directories; testclient.log file should be generated inside target directory
Diffs
-----
plugins/network-elements/juniper-contrail/test/resources/log4j.properties 138a961
Diff: https://reviews.apache.org/r/17506/diff/
Testing
-------
verified locally
Thanks,
Suresh Balineni
Re: Review Request 17506: mvn clean - test logs- contrail -cleanps up only
target, dist directories;
testclient.log file should be generated inside target directory
Posted by Suresh Balineni <sb...@juniper.net>.
> On March 3, 2014, 9:30 a.m., daan Hoogland wrote:
> > is this still valid? It is not applied on master. Should it be?
This must be applied to master branch.
- Suresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17506/#review35951
-----------------------------------------------------------
On Jan. 29, 2014, 6:56 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17506/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 6:56 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> mvn clean - cleanps up only target, dist directories; testclient.log file should be generated inside target directory
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties 138a961
>
> Diff: https://reviews.apache.org/r/17506/diff/
>
>
> Testing
> -------
>
> verified locally
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 17506: mvn clean - test logs- contrail -cleanps up only
target, dist directories;
testclient.log file should be generated inside target directory
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17506/#review35951
-----------------------------------------------------------
is this still valid? It is not applied on master. Should it be?
- daan Hoogland
On Jan. 29, 2014, 6:56 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17506/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 6:56 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> mvn clean - cleanps up only target, dist directories; testclient.log file should be generated inside target directory
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties 138a961
>
> Diff: https://reviews.apache.org/r/17506/diff/
>
>
> Testing
> -------
>
> verified locally
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 17506: mvn clean - test logs- contrail -cleanps up only
target, dist directories;
testclient.log file should be generated inside target directory
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17506/#review36106
-----------------------------------------------------------
Ship it!
e2f9c11ad3851ab5fd5749474cd11abe970db997
- daan Hoogland
On Jan. 29, 2014, 6:56 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17506/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 6:56 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> mvn clean - cleanps up only target, dist directories; testclient.log file should be generated inside target directory
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/resources/log4j.properties 138a961
>
> Diff: https://reviews.apache.org/r/17506/diff/
>
>
> Testing
> -------
>
> verified locally
>
>
> Thanks,
>
> Suresh Balineni
>
>