You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/08/16 00:29:50 UTC
[6/6] impala git commit: IMPALA-7442: reduce mem requirement of
semi-joins-exhaustive
IMPALA-7442: reduce mem requirement of semi-joins-exhaustive
The test started running into IMPALA-7446, maybe because of
a timing change. This appears to have always been possible.
The fix is to reduce the memory requirement of the test.
IMPALA-2256 is no longer really possible because the
BufferedTupleStream code was simplified to avoid the 32-bit
row index limitation, so we're not losing important coverage
on the current code with this change.
Testing:
Ran test in a loop to confirm it did not OOM.
Change-Id: I9d9480cad6bf8222abe990e7046498a0531e2849
Reviewed-on: http://gerrit.cloudera.org:8080/11223
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/29905d1e
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/29905d1e
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/29905d1e
Branch: refs/heads/master
Commit: 29905d1ea41b3c0e7ceebf913981173292dfffbf
Parents: 48fdd0b
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Tue Aug 14 16:22:55 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Aug 16 00:21:54 2018 +0000
----------------------------------------------------------------------
.../queries/QueryTest/semi-joins-exhaustive.test | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/29905d1e/testdata/workloads/functional-query/queries/QueryTest/semi-joins-exhaustive.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/semi-joins-exhaustive.test b/testdata/workloads/functional-query/queries/QueryTest/semi-joins-exhaustive.test
index a73b0ec..2a7f101 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/semi-joins-exhaustive.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/semi-joins-exhaustive.test
@@ -1,18 +1,17 @@
====
---- QUERY
-# Regression test for IMPALA-2256. Join whose right side has very high
-# cardinality (60M) and zero materialized slots.
-# Because the right side of the join here is always
-# the same key, this query can run out of memory and fail to spill; see
-# IMPALA-4857. The cardinality (60M) is chosen so that the test
-# runs when impalad has a 7.8GB memlimit. (The peak memory usage
-# of the relevant fragment is 3.6GB when tested.)
+# Regression test for IMPALA-2256. Join whose right side has high cardinality and
+# zero materialized slots. Because the right side of the join here is always the
+# same key, this query can run out of memory and fail to spill; see IMPALA-4856.
+# The cardinality (~12M) is chosen so that the test run successfully in parallel
+# with other tests when impalad has a 7.8GB memlimit. (The peak memory usage of
+# the relevant fragment is ~850MB when tested.)
SELECT straight_join
COUNT(*) FROM alltypesagg t1
WHERE t1.int_col IN (
SELECT 1 FROM alltypesagg t1
CROSS JOIN alltypesagg t2
- WHERE t1.int_col < 500)
+ WHERE t1.int_col < 100)
---- RESULTS
10
---- TYPES