You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/12 08:42:20 UTC
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request
#5154: remove remaining stale functions
strongduanmu opened a new pull request #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154
Fixes #5136 .
Changes proposed in this pull request:
- remove stale functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5154:
remove remaining stale functions
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154#issuecomment-612585381
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=h1) Report
> Merging [#5154](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/9aecf8481b657fc2c646e64d60d6e03e419769e0&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5154 +/- ##
============================================
+ Coverage 54.07% 54.19% +0.11%
Complexity 406 406
============================================
Files 1154 1154
Lines 20537 20493 -44
Branches 3711 3695 -16
============================================
Hits 11106 11106
+ Misses 8742 8698 -44
Partials 689 689
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sql/parser/mysql/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/parser/oracle/visitor/impl/OracleDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvaW1wbC9PcmFjbGVETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL2ltcGwvU1FMOTJETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvaW1wbC9TUUxTZXJ2ZXJETUxWaXNpdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=footer). Last update [9aecf84...2f94ef5](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5154?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #5154:
remove remaining stale functions
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154#issuecomment-612849891
> @strongduanmu Hi Thanks for your rapid PR and good job. 👍
It's my pleasure.😀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5154:
remove remaining stale functions
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154#issuecomment-612756164
@strongduanmu Hi Thanks for your rapid PR and good job. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5154:
remove remaining stale functions
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5154:
remove remaining stale functions
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5154: remove remaining stale functions
URL: https://github.com/apache/incubator-shardingsphere/pull/5154#issuecomment-612585733
## Pull Request Test Coverage Report for [Build 10991](https://coveralls.io/builds/30019338)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.1%**) to **57.62%**
---
| Totals | [](https://coveralls.io/builds/30019338) |
| :-- | --: |
| Change from base [Build 10990](https://coveralls.io/builds/30018792): | 0.1% |
| Covered Lines: | 11808 |
| Relevant Lines: | 20493 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services