You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/09 22:37:40 UTC
[GitHub] [flink] tweise commented on a change in pull request #10285:
[FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to
flink-shaded
tweise commented on a change in pull request #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
URL: https://github.com/apache/flink/pull/10285#discussion_r355724390
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -193,25 +193,30 @@ under the License.
<artifactSet combine.children="append">
<includes>
<include>com.amazonaws:*</include>
+ <include>com.fasterxml:*</include>
<include>com.google.protobuf:*</include>
<include>org.apache.httpcomponents:*</include>
<!-- Java 11 specific inclusion; should be a no-op for other versions -->
<include>javax.xml.bind:jaxb-api</include>
</includes>
</artifactSet>
<relocations combine.children="override">
- <!-- DO NOT RELOCATE GUAVA IN THIS PACKAGE -->
<relocation>
- <pattern>com.google.protobuf</pattern>
- <shadedPattern>org.apache.flink.kinesis.shaded.com.google.protobuf</shadedPattern>
+ <pattern>com.amazonaws</pattern>
+ <shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.amazonaws</shadedPattern>
</relocation>
<relocation>
- <pattern>com.amazonaws</pattern>
- <shadedPattern>org.apache.flink.kinesis.shaded.com.amazonaws</shadedPattern>
+ <pattern>com.fasterxml</pattern>
+ <shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.fasterxml</shadedPattern>
+ </relocation>
+ <!-- DO NOT RELOCATE GUAVA IN THIS PACKAGE -->
Review comment:
I see it used in `KinesisProducer`, but not on the API surface. We should be able to use flink shaded in this case, since we already depend on it via `flink-streaming-java`:
```
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ flink-connector-kinesis_2.11 ---
[INFO] org.apache.flink:flink-connector-kinesis_2.11:jar:1.11-SNAPSHOT
[INFO] +- org.apache.flink:flink-streaming-java_2.11:jar:1.11-SNAPSHOT:provided
[INFO] | +- org.apache.flink:flink-core:jar:1.11-SNAPSHOT:provided
[INFO] | +- org.apache.flink:flink-runtime_2.11:jar:1.11-SNAPSHOT:provided
[INFO] | +- org.apache.flink:flink-clients_2.11:jar:1.11-SNAPSHOT:provided
[INFO] | | \- org.apache.flink:flink-optimizer_2.11:jar:1.11-SNAPSHOT:provided
[INFO] | +- org.apache.flink:flink-shaded-guava:jar:18.0-9.0:provided
[INFO] | \- org.apache.commons:commons-math3:jar:3.5:provided
[INFO] +- com.google.guava:guava:jar:18.0:compile
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services