You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "eddelbuettel (via GitHub)" <gi...@apache.org> on 2023/05/16 20:53:25 UTC
[GitHub] [arrow] eddelbuettel opened a new pull request, #35626: GH-35617: [Docs] Current n_buffers use in C API example
eddelbuettel opened a new pull request, #35626:
URL: https://github.com/apache/arrow/pull/35626
closes #35617
### Rationale for this change
As described in #35617 the example in docs suffers from a likely copy-and-paste error as the `n_buffers` value references the _parent_ rather that the two children where this is used. `g++-12` spots this and bemoans that assigning to, respectively, `buffers[1]` and then `buffers[1]` and `buffers[2]` is out of bounds.
### What changes are included in this PR?
The example is corrected.
### Are these changes tested?
Yes, locally. The warnings under `g++-12` go away.
### Are there any user-facing changes?
Not in behavior but the documentation is improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35626: GH-35617: [Docs] Current n_buffers use in C API example
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35626:
URL: https://github.com/apache/arrow/pull/35626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35626: GH-35617: [Docs] Current n_buffers use in C API example
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35626:
URL: https://github.com/apache/arrow/pull/35626#issuecomment-1550347810
:warning: GitHub issue #35617 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35626: GH-35617: [Docs] Current n_buffers use in C API example
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35626:
URL: https://github.com/apache/arrow/pull/35626#issuecomment-1554660563
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0b143b550ff8499190c46f8e870e4a8d...9010f7e69d1b409ca75d87940dacf455/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35626: GH-35617: [Docs] Current n_buffers use in C API example
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35626:
URL: https://github.com/apache/arrow/pull/35626#issuecomment-1550347766
* Closes: #35617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35626: GH-35617: [Docs] Current n_buffers use in C API example
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35626:
URL: https://github.com/apache/arrow/pull/35626#issuecomment-1554656308
Benchmark runs are scheduled for baseline = 88339cd8aa0c023791566085fa659e0c99d22161 and contender = aaf62591741a2f3b4df0d84273ebdbdcb01a8005. aaf62591741a2f3b4df0d84273ebdbdcb01a8005 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3bc6a9e30d264f7887b1edb517192fdc...92914c4c226040259122f84d69964f99/)
[Finished :arrow_down:0.44% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fb1b88b5690940208fda0e55ea70b37c...b9cf8d73dcb440e2b22dbf48189aff35/)
[Finished :arrow_down:1.78% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0b143b550ff8499190c46f8e870e4a8d...9010f7e69d1b409ca75d87940dacf455/)
[Finished :arrow_down:1.75% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ee9e3598d9db4ab789645c7e10a2e6ef...004fc166d33948c39daf940f24030347/)
Buildkite builds:
[Finished] [`aaf62591` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2885)
[Finished] [`aaf62591` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2921)
[Finished] [`aaf62591` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2886)
[Finished] [`aaf62591` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2911)
[Finished] [`88339cd8` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2884)
[Finished] [`88339cd8` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2920)
[Finished] [`88339cd8` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2885)
[Finished] [`88339cd8` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2910)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org