You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/23 13:53:51 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #2325: [NETBEANS-4620] NullPointerException - finding occurrences
junichi11 opened a new pull request #2325:
URL: https://github.com/apache/netbeans/pull/2325
To avoid NPE, check new value is not `null` but `Caret`. If it's `null`, `BasicTextUI.editor` field may be `null`.
```
java.lang.NullPointerException
at java.desktop/javax.swing.plaf.basic.BasicTextUI.modelToView(BasicTextUI.java:1104)
at java.desktop/javax.swing.plaf.basic.BasicTextUI.modelToView(BasicTextUI.java:1089)
at java.desktop/javax.swing.plaf.basic.BasicTextUI.modelToView(BasicTextUI.java:1065)
at org.netbeans.modules.editor.search.SearchComboBoxEditor$ManageViewPositionListener.changed(SearchComboBoxEditor.java:290)
at org.netbeans.modules.editor.search.SearchComboBoxEditor$ManageViewPositionListener.removeUpdate(SearchComboBoxEditor.java:277)
at org.netbeans.lib.editor.util.swing.PriorityDocumentListenerList.removeUpdate(PriorityDocumentListenerList.java:91)
at java.desktop/javax.swing.text.AbstractDocument.fireRemoveUpdate(AbstractDocument.java:261)
at org.netbeans.editor.BaseDocument.fireRemoveUpdate(BaseDocument.java:1650)
at org.netbeans.editor.BaseDocument.handleRemove(BaseDocument.java:1022)
at org.netbeans.editor.BaseDocument$FilterBypassImpl.remove(BaseDocument.java:2639)
at java.desktop/javax.swing.text.DocumentFilter.remove(DocumentFilter.java:79)
at org.netbeans.editor.BaseDocument.remove(BaseDocument.java:935)
at org.netbeans.modules.editor.search.SearchComboBoxEditor$3.propertyChange(SearchComboBoxEditor.java:137)
```
CC: @DevCharly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #2325: [NETBEANS-4620] NullPointerException - finding occurrences
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #2325:
URL: https://github.com/apache/netbeans/pull/2325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2325: [NETBEANS-4620] NullPointerException - finding occurrences
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2325:
URL: https://github.com/apache/netbeans/pull/2325#issuecomment-678944248
@lkishalmi not sure this should be backported for 12.0-u2 - #2188 is in 12.1 not 12.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2325: [NETBEANS-4620] NullPointerException - finding occurrences
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2325:
URL: https://github.com/apache/netbeans/pull/2325#issuecomment-678823685
@neilcsmith-net
> So this is from fix for NB-4444, and a regression between 12.0 and 12.1?
Yes, I think so. (#2188)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2325: [NETBEANS-4620] NullPointerException - finding occurrences
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2325:
URL: https://github.com/apache/netbeans/pull/2325#issuecomment-678808405
Thanks @junichi11 So this is from fix for NB-4444, and a regression between 12.0 and 12.1? Agree we should merge for release, even if that delays us a few days. Need to work out what to do about commits that went in to master without being intended for 12.1.
cc @geertjanw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists