You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/01/30 22:12:11 UTC

[GitHub] beam pull request #1873: [BEAM-1350] BigQuery: refactor services so that all...

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/1873

    [BEAM-1350] BigQuery: refactor services so that all queryConfig happens in BigQueryIO

    By putting all the configuration in the same place, we can avoid
    bugs that happen from mismatching code across files.
    
    Also made a few unnecessarily-public APIs package-private.
    
    And improved tests, removed a few dataflow references.
    
    Forward port from Dataflow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam bigquery-io-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1873
    
----
commit e643a85cbf64687de024ca0dc0f34b9c6ae451f5
Author: Dan Halperin <dh...@google.com>
Date:   2017-01-30T22:04:32Z

    BigQuery: refactor services so that all queryConfig happens in BigQueryIO
    
    By putting all the configuration in the same place, we can avoid
    bugs that happen from mismatching code across files.
    
    Also made a few unnecessarily-public APIs package-private.
    
    And improved tests, removed a few dataflow references.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1873: [BEAM-1350] BigQuery: refactor services so that all...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1873


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---