You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "AuruTus (via GitHub)" <gi...@apache.org> on 2023/04/03 08:56:54 UTC

[GitHub] [apisix-ingress-controller] AuruTus opened a new pull request, #1766: docs: Add lost entries of `discovery` in Upstream's reference doc.

AuruTus opened a new pull request, #1766:
URL: https://github.com/apache/apisix-ingress-controller/pull/1766

   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   <!-- Select all the options from below that matches the type your PR best -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Documentation
   - [ ] Refactor
   - [ ] Chore
   - [ ] CI/CD or Tests
   
   ### What this PR does / why we need it:
   
   Fix #1740 
   
   Add entries and their descriptions for service discovery in ApisixUpstream's reference doc.
   
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1766: docs: Add lost entries of `discovery` in Upstream's reference doc.

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1766:
URL: https://github.com/apache/apisix-ingress-controller/pull/1766#issuecomment-1495223632

   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1766: docs: Add lost entries of `discovery` in Upstream's reference doc.

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1766:
URL: https://github.com/apache/apisix-ingress-controller/pull/1766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] AuruTus commented on pull request #1766: docs: Add lost entries of `discovery` in Upstream's reference doc.

Posted by "AuruTus (via GitHub)" <gi...@apache.org>.
AuruTus commented on PR #1766:
URL: https://github.com/apache/apisix-ingress-controller/pull/1766#issuecomment-1494181591

   Emmm, I'm not familiar with markdown lint tools, and the `tmknom/markdownlint` doesn't report any lint warning or error, so I configured the table cell width by hand 😅, rebased and force-pushed this change. BTW, hope I don't misunderstand what these added fields are used for.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org