You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/10 21:21:27 UTC
[GitHub] [thrift] Jens-G opened a new pull request, #2658: THRIFT-5626 Parser should not confuse data types and field names
Jens-G opened a new pull request, #2658:
URL: https://github.com/apache/thrift/pull/2658
Patch: Jens Geyer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2658: THRIFT-5626 Parser should not confuse data types and field names
Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2658:
URL: https://github.com/apache/thrift/pull/2658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on a diff in pull request #2658: THRIFT-5626 Parser should not confuse data types and field names
Posted by GitBox <gi...@apache.org>.
Jens-G commented on code in PR #2658:
URL: https://github.com/apache/thrift/pull/2658#discussion_r967798370
##########
test/v0.16/NameConflictTest.thrift:
##########
@@ -0,0 +1,124 @@
+// Naming testcases, sepcifically for these tickets (but not limited to them)
Review Comment:
good catch, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2658: THRIFT-5626 Parser should not confuse data types and field names
Posted by GitBox <gi...@apache.org>.
fishy commented on code in PR #2658:
URL: https://github.com/apache/thrift/pull/2658#discussion_r967757643
##########
test/v0.16/NameConflictTest.thrift:
##########
@@ -0,0 +1,124 @@
+// Naming testcases, sepcifically for these tickets (but not limited to them)
Review Comment:
should this file also add the Apache License header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org