You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2021/04/27 06:08:44 UTC

[GitHub] [struts] yasserzamani commented on pull request #485: [WW-5126] use == instead of .equals in ModelDrivenInterceptor

yasserzamani commented on pull request #485:
URL: https://github.com/apache/struts/pull/485#issuecomment-827339324


   Thanks for the review @aleksandr-m !
   
   TBH I don't have a strong reason. [I've asked reporter](https://issues.apache.org/jira/browse/WW-5126?focusedCommentId=17329388&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17329388) but no answer yet.
   
   "Moreover the interceptor refresh process is based on call to the equals method and this method may have been redefined, in a JPA context for instance. The replacement is then not systematic and may not be done." he said. No user ever has asked for `.equals` so I guess `.equals` has been selected unintentionally and the reporter has found a valid case that shows that it should be `==`. That was my reasoning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org