You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/05 05:37:50 UTC

[kudu-CR] [clock] fix on SystemNtp::Init()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15163


Change subject: [clock] fix on SystemNtp::Init()
......................................................................

[clock] fix on SystemNtp::Init()

Do not require the clock to be synchronized to read the clock frequency
tolerance via ntp_adjtime().

This is a follow-up to e72208436a625391739217394c67d783e992367a.

Change-Id: I0b4a64d422d417e86e621d0d42d715d7046fc0b8
---
M src/kudu/clock/system_ntp.cc
1 file changed, 22 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/15163/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b4a64d422d417e86e621d0d42d715d7046fc0b8
Gerrit-Change-Number: 15163
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clock] fix on SystemNtp::Init()

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15163 )

Change subject: [clock] fix on SystemNtp::Init()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b4a64d422d417e86e621d0d42d715d7046fc0b8
Gerrit-Change-Number: 15163
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 18:29:41 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] fix on SystemNtp::Init()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15163 )

Change subject: [clock] fix on SystemNtp::Init()
......................................................................

[clock] fix on SystemNtp::Init()

Do not require the clock to be synchronized to read the clock frequency
tolerance via ntp_adjtime().

This is a follow-up to e72208436a625391739217394c67d783e992367a.

Change-Id: I0b4a64d422d417e86e621d0d42d715d7046fc0b8
Reviewed-on: http://gerrit.cloudera.org:8080/15163
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/system_ntp.cc
1 file changed, 22 insertions(+), 16 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b4a64d422d417e86e621d0d42d715d7046fc0b8
Gerrit-Change-Number: 15163
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>