[GitHub] [accumulo] keith-turner edited a comment on issue #2495: Explore consistently formatting all ids in Accumulo logs.

[GitBox <gi...@apache.org>]

keith-turner edited a comment on issue #2495:
URL: https://github.com/apache/accumulo/issues/2495#issuecomment-1040421907


   So far it seems like there are three viable options (with the log4j specific option not being viable) 
   
   - Modify toString() on AbstractId to format the id and include a type
     - Cons: have to find all places where this is not suitable and change to canonical().  Could lead to errors when constructing metadata table entries and ZK/DFS paths.
     - Pros: New code written that logs the id will automatically use the formatted id.  For user facing output devs usually test that when writing it and if they don;t like toString() output they can switch to canonical().
   - Add a new method to AbstractId to format the id and include a type.
      - Cons: Have to modify all existing logging to call new method.  Have to remember to use the new method when writing new logging stmts.
      - Pros: canonical() and toString() are the same, the more I think about this not a huge pro.
   - Do nothing
     - Cons : Logging does consistently include type w/ id.
     - Pros: So easy to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org