You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gump.apache.org by bo...@apache.org on 2010/09/27 11:07:30 UTC
svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Author: bodewig
Date: Mon Sep 27 09:07:30 2010
New Revision: 1001631
URL: http://svn.apache.org/viewvc?rev=1001631&view=rev
Log:
I don't know why wildcards sometimes don't seem to work
Modified:
gump/metadata/project/checkstyle.xml
Modified: gump/metadata/project/checkstyle.xml
URL: http://svn.apache.org/viewvc/gump/metadata/project/checkstyle.xml?rev=1001631&r1=1001630&r2=1001631&view=diff
==============================================================================
--- gump/metadata/project/checkstyle.xml (original)
+++ gump/metadata/project/checkstyle.xml Mon Sep 27 09:07:30 2010
@@ -37,7 +37,7 @@
<option project="commons-validator"/>
<option project="junit"/>
- <jar name="target/checkstyle-*[0-9T].jar"
+ <jar name="target/checkstyle-5.3-SNAPSHOT.jar"
id="checkstyle"/>
<license name="LICENSE"/>
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by sebb <se...@gmail.com>.
On 27 September 2010 11:56, Maarten Coene <ma...@yahoo.com> wrote:
> If the pattern has to be a regular expression, it should be:
> <jar name="target/checkstyle-.*[0-9T].jar" />
I've just found that it's a shell glob pattern:
http://gump.apache.org/metadata/project.html#jar
> Maarten
>
> --- On Mon, 9/27/10, Stefan Bodewig <bo...@apache.org> wrote:
>
>> From: Stefan Bodewig <bo...@apache.org>
>> Subject: Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
>> To: general@gump.apache.org
>> Date: Monday, September 27, 2010, 12:48 PM
>> On 2010-09-27, sebb wrote:
>>
>> > On 27 September 2010 10:07, <bo...@apache.org>
>> wrote:
>>
>> >> I don't know why wildcards sometimes don't seem to
>> work
>>
>> >> - <jar
>> name="target/checkstyle-*[0-9T].jar"
>> >> + <jar
>> name="target/checkstyle-5.3-SNAPSHOT.jar"
>>
>> > Perhaps they don't work because of the -SNAPSHOT
>> suffix?
>>
>> No, that works in several other projects. And the
>> wildcard should still
>> match anyway (that's why there is a T in the group).
>>
>> My best guess currently is - and confirming/fixing it is on
>> my TODO
>> list, somewhere - that under certain circumstances the
>> wildcards get
>> expanded before the jar has actually been built.
>>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
>> For additional commands, e-mail: general-help@gump.apache.org
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-09-27, sebb wrote:
> On 27 September 2010 11:48, Stefan Bodewig <bo...@apache.org> wrote:
>> On 2010-09-27, sebb wrote:
>>> On 27 September 2010 10:07, <bo...@apache.org> wrote:
>>>> I don't know why wildcards sometimes don't seem to work
>> My best guess currently is - and confirming/fixing it is on my TODO
>> list, somewhere - that under certain circumstances the wildcards get
>> expanded before the jar has actually been built.
> What happens if the wildcard matches more than one file?
You get an error but with a different error message.
See the expand_outputs method in
http://svn.apache.org/repos/asf/gump/trunk/python/gump/core/model/project.py
If the pattern doesn't match anything, the error code is set later in a
different location and you only see the debug statement. If it matches
more than one file the error message would tell you how many it has
matched.
Hmm, now that I see the code, I think I spot the problem, the last line
should be indented one level deeper so it only sets the outputs_expanded
property to true if outputs have actually been expanded. I'll try that
in my sandbox and commit the change to trunk this evening. It doesn't
explain why the method sometimes is invoked with self.built being false,
but it should delay the expansion.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by sebb <se...@gmail.com>.
On 27 September 2010 11:48, Stefan Bodewig <bo...@apache.org> wrote:
> On 2010-09-27, sebb wrote:
>
>> On 27 September 2010 10:07, <bo...@apache.org> wrote:
>
>>> I don't know why wildcards sometimes don't seem to work
>
>>> - <jar name="target/checkstyle-*[0-9T].jar"
>>> + <jar name="target/checkstyle-5.3-SNAPSHOT.jar"
>
>> Perhaps they don't work because of the -SNAPSHOT suffix?
>
> No, that works in several other projects. And the wildcard should still
> match anyway (that's why there is a T in the group).
>
Sorry, I see now. I wondered what the T was doing!
> My best guess currently is - and confirming/fixing it is on my TODO
> list, somewhere - that under certain circumstances the wildcards get
> expanded before the jar has actually been built.
What happens if the wildcard matches more than one file?
Could that cause a problem for the code?
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by Maarten Coene <ma...@yahoo.com>.
If the pattern has to be a regular expression, it should be:
<jar name="target/checkstyle-.*[0-9T].jar" />
Maarten
--- On Mon, 9/27/10, Stefan Bodewig <bo...@apache.org> wrote:
> From: Stefan Bodewig <bo...@apache.org>
> Subject: Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
> To: general@gump.apache.org
> Date: Monday, September 27, 2010, 12:48 PM
> On 2010-09-27, sebb wrote:
>
> > On 27 September 2010 10:07, <bo...@apache.org>
> wrote:
>
> >> I don't know why wildcards sometimes don't seem to
> work
>
> >> - <jar
> name="target/checkstyle-*[0-9T].jar"
> >> + <jar
> name="target/checkstyle-5.3-SNAPSHOT.jar"
>
> > Perhaps they don't work because of the -SNAPSHOT
> suffix?
>
> No, that works in several other projects. And the
> wildcard should still
> match anyway (that's why there is a T in the group).
>
> My best guess currently is - and confirming/fixing it is on
> my TODO
> list, somewhere - that under certain circumstances the
> wildcards get
> expanded before the jar has actually been built.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-09-27, sebb wrote:
> On 27 September 2010 10:07, <bo...@apache.org> wrote:
>> I don't know why wildcards sometimes don't seem to work
>> - <jar name="target/checkstyle-*[0-9T].jar"
>> + <jar name="target/checkstyle-5.3-SNAPSHOT.jar"
> Perhaps they don't work because of the -SNAPSHOT suffix?
No, that works in several other projects. And the wildcard should still
match anyway (that's why there is a T in the group).
My best guess currently is - and confirming/fixing it is on my TODO
list, somewhere - that under certain circumstances the wildcards get
expanded before the jar has actually been built.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r1001631 - /gump/metadata/project/checkstyle.xml
Posted by sebb <se...@gmail.com>.
On 27 September 2010 10:07, <bo...@apache.org> wrote:
> Author: bodewig
> Date: Mon Sep 27 09:07:30 2010
> New Revision: 1001631
>
> URL: http://svn.apache.org/viewvc?rev=1001631&view=rev
> Log:
> I don't know why wildcards sometimes don't seem to work
>
> Modified:
> gump/metadata/project/checkstyle.xml
>
> Modified: gump/metadata/project/checkstyle.xml
> URL: http://svn.apache.org/viewvc/gump/metadata/project/checkstyle.xml?rev=1001631&r1=1001630&r2=1001631&view=diff
> ==============================================================================
> --- gump/metadata/project/checkstyle.xml (original)
> +++ gump/metadata/project/checkstyle.xml Mon Sep 27 09:07:30 2010
> @@ -37,7 +37,7 @@
> <option project="commons-validator"/>
> <option project="junit"/>
>
> - <jar name="target/checkstyle-*[0-9T].jar"
> + <jar name="target/checkstyle-5.3-SNAPSHOT.jar"
Perhaps they don't work because of the -SNAPSHOT suffix?
> id="checkstyle"/>
>
> <license name="LICENSE"/>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org