[GitHub] [hive] dengzhhu653 edited a comment on pull request #2344: HIVE-23633: Metastore some JDO query objects do not close …

[GitBox <gi...@apache.org>]

dengzhhu653 edited a comment on pull request #2344:
URL: https://github.com/apache/hive/pull/2344#issuecomment-933060720


   > > Hi @pvary, cloud you help merge this? thank you! :)
   > 
   > Ahh... Sorry for forgetting about this review. Could you please ping @belugabehr to check if he is OK with the current solution?
   > 
   > Also we will need to rebase / rerun the tests. I see that theoretically it can be merged without a conflict, but I have had headache several times before with merging changes with outdated tests which caused problems for the next contributor.
   > 
   > Thanks for keeping this PR alive @dengzhhu653!
   
   Thank you very much for the feedback and sorry for the late reply, I will rebase the commits. Hey @belugabehr, cloud you please take another look if have secs?
   The issue can be seen in the long live shared Metastore client(spark, client pool), the unreleased queries would accumulate to seeing the OOM. The former patch we applied to Hive version 1.2 solved it,  this patch introduces try-with-resource on the query and a sanity check on the master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org