You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/27 18:37:44 UTC

[GitHub] [maven-surefire] Tibor17 opened a new pull request #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Tibor17 opened a new pull request #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259
 
 
   Updated after PR #253 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-surefire] Tibor17 commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259#issuecomment-569468026
 
 
   I have cherrypicked the commits to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259#issuecomment-569413444
 
 
   @olamy 
   No, of course not, but here I wanted to demonstrate whether commit from Jonathan would be stable after the latest chnages.
   I think Jonathan's commit would be fine but it truly provocated the issue in [SUREFIRE-1719](https://issues.apache.org/jira/browse/SUREFIRE-1719) and therefore the issue SUREFIRE-1719 should be fixed before the PR #253 . At the Slack we talked about it so that the failed test `ForkModeIT_testForkCountTwoNoReuse` is related to the same symptoms with `reuseForks=false` and also we uncovered the root cause https://issues.apache.org/jira/browse/SUREFIRE-1719?focusedCommentId=16977946&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16977946

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-surefire] Tibor17 commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259#issuecomment-569413444
 
 
   @olamy 
   No, of course not, but here I wanted to demonstrate whether commit from Jonathan would be stable.
   I think Jonathan's commit would be fine but it truly provocated the issue in [SUREFIRE-1719](https://issues.apache.org/jira/browse/SUREFIRE-1719) and therefore the issue SUREFIRE-1719 should be fixed before the PR #253 . At the Slack we talked about it so that the failed test `ForkModeIT_testForkCountTwoNoReuse` is related to the same symptoms with `reuseForks=false` and also we uncovered the root cause https://issues.apache.org/jira/browse/SUREFIRE-1719?focusedCommentId=16977946&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16977946

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-surefire] olamy commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Posted by GitBox <gi...@apache.org>.
olamy commented on issue #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259#issuecomment-569402969
 
 
   Are all package name changes related to the issue mentioned in the description? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-surefire] Tibor17 closed pull request #259: [SUREFIRE-1516] Poor performance in reuseForks=false

Posted by GitBox <gi...@apache.org>.
Tibor17 closed pull request #259: [SUREFIRE-1516] Poor performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/259
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services