[GitHub] [tvm] gigiblender commented on a diff in pull request #12332: [CI] Deduplicate and clean XML test reports

[GitBox <gi...@apache.org>]

gigiblender commented on code in PR #12332:
URL: https://github.com/apache/tvm/pull/12332#discussion_r940541356


##########
conftest.py:
##########
@@ -92,14 +92,11 @@ def pytest_collection_modifyitems(config, items):
     shard_index = int(os.environ["TVM_SHARD_INDEX"])
 
     print(f"Marking tests for shard {shard_index} of {num_shards}")
-    for item in items:
+    items_copy = list(items)
+    for item in items_copy:
         item_shard_index = find_shard_index(item.nodeid, num_shards=num_shards)
-        item.add_marker(
-            pytest.mark.skipif(
-                item_shard_index != shard_index,
-                reason=f"Test running on shard {item_shard_index} of {num_shards}",
-            )
-        )
+        if item_shard_index != shard_index:
+            items.remove(item)

Review Comment:
   I am not very sure how we could make this a better UX. 
   I understand your concern, but I'm wondering how often someone does a manual search for a specific test through the shard logs. If a test fails, the corresponding shard will appear red in the UI. 
   
   Alternatively, we can keep the old log structure (showing the skipped tests), and I can filter them later when processing the XML logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org