You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chaoyu Tang <ct...@gmail.com> on 2015/11/07 17:06:26 UTC
Review Request 40048: HIVE-12365: Added resource path is sent to
cluster as an empty string when externally removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40048/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-12365
https://issues.apache.org/jira/browse/HIVE-12365
Repository: hive-git
Description
-------
Sometimes the resources (e.g. jar) added via command like "add jars <filepath>" are removed externally from their filepath for some reasons. Their paths are sent to cluster as empty strings which causes the failures to the query that even do not need these jars in execution. Hive should not include these paths in the value to job config such as tmpjars etc.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 02adf0c
ql/src/test/queries/clientpositive/add_jar_with_file_removed.q PRE-CREATION
ql/src/test/results/clientpositive/add_jar_with_file_removed.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/40048/diff/
Testing
-------
1. new qtests
2. precommit build
Thanks,
Chaoyu Tang
Re: Review Request 40048: HIVE-12365: Added resource path is sent to
cluster as an empty string when externally removed
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40048/#review105601
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Nov. 7, 2015, 4:06 p.m., Chaoyu Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40048/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 4:06 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-12365
> https://issues.apache.org/jira/browse/HIVE-12365
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Sometimes the resources (e.g. jar) added via command like "add jars <filepath>" are removed externally from their filepath for some reasons. Their paths are sent to cluster as empty strings which causes the failures to the query that even do not need these jars in execution. Hive should not include these paths in the value to job config such as tmpjars etc.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 02adf0c
> ql/src/test/queries/clientpositive/add_jar_with_file_removed.q PRE-CREATION
> ql/src/test/results/clientpositive/add_jar_with_file_removed.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40048/diff/
>
>
> Testing
> -------
>
> 1. new qtests
> 2. precommit build
>
>
> Thanks,
>
> Chaoyu Tang
>
>