You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/08/12 04:20:36 UTC

[PR] [Subscription] Exclude audit database from subscriptions [iotdb]

Caideyipi opened a new pull request, #18451:
URL: https://github.com/apache/iotdb/pull/18451

   ## Description
   
   ### Content1
   Exclude the internal audit database from subscription source selection. The shared audit-database matcher recognizes `__audit`, `root.__audit`, case variants, and their descendants without matching similarly named user databases.
   
   ### Content2
   Apply the matcher to both Pipe-backed and consensus subscription setup paths. Existing audit DataRegions are not registered, and newly created audit DataRegions do not create subscription queues.
   
   ### Content3
   Add focused unit coverage for audit database matching, Pipe DataRegion filtering, and consensus subscription setup.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   
   - `Audit`
   - `DataRegionListeningFilter`
   - `ConsensusSubscriptionSetupHandler`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Subscription] Exclude audit database from subscriptions [iotdb]

Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on PR #18451:
URL: https://github.com/apache/iotdb/pull/18451#issuecomment-5276657347

   Thanks, addressed in 321b94982e1. Topic creation and alteration now reject table topics whose effective database filter explicitly targets only \__audit\, and tree topics whose effective inclusion paths are all under \ oot.__audit\. Mixed audit/user filters remain allowed, with focused create, alter, source override, and inclusion/exclusion coverage added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Subscription] Exclude audit database from subscriptions [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18451:
URL: https://github.com/apache/iotdb/pull/18451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org