You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:44:21 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1029: Remove commented out code in participant manager
zhangmeng916 opened a new pull request #1029:
URL: https://github.com/apache/helix/pull/1029
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#1026 )
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Remove commented out code in Helix participant manager for clarity.
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
in helix-core:
[ERROR] Failures:
[ERROR] TestClusterInMaintenanceModeWhenReachingMaxPartition.testDisableCluster:119 expected:<true> but was:<false>
[ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp:107 ยป ThreadTimeout Method org.tes...
[ERROR] TestRebalanceRunningTask.testFixedTargetTaskAndDisabledRebalanceAndNodeAdded:297 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1147, Failures: 3, Errors: 0, Skipped: 1
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1029: Remove commented out code in participant manager
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1029:
URL: https://github.com/apache/helix/pull/1029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1029: Remove commented out code in participant manager
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1029:
URL: https://github.com/apache/helix/pull/1029#issuecomment-634298494
This PR is ready to merge. Approved by @narendly
Final commit message: Remove commented out code in participant manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org