You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/16 16:10:06 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request #14813: Improve show transaction rule
RaigorJiang opened a new pull request #14813:
URL: https://github.com/apache/shardingsphere/pull/14813
Fixes #14770.
After adding props to `TransactionRuleConfiguration`, update the result set of `SHOW TRANSACTION RULE` to match it.
Changes proposed in this pull request:
- update ShowTransactionRuleExecutor
- update ShowTransactionRuleExecutorTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #14813: Add props to the result set of `SHOW TRANSACTION RULE`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14813:
URL: https://github.com/apache/shardingsphere/pull/14813#issuecomment-1013941552
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14813](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5cafda) into [master](https://codecov.io/gh/apache/shardingsphere/commit/42750ae6de421377d487dff6d7924a0a71253282?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42750ae) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14813 +/- ##
=========================================
Coverage 59.16% 59.16%
Complexity 1845 1845
=========================================
Files 3085 3085
Lines 46401 46402 +1
Branches 7869 7870 +1
=========================================
+ Hits 27454 27455 +1
Misses 16784 16784
Partials 2163 2163
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/show/executor/ShowTransactionRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/14813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9zaG93L2V4ZWN1dG9yL1Nob3dUcmFuc2FjdGlvblJ1bGVFeGVjdXRvci5qYXZh) | `84.61% <100.00%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [42750ae...a5cafda](https://codecov.io/gh/apache/shardingsphere/pull/14813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #14813: Add props to the result set of `SHOW TRANSACTION RULE`
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #14813:
URL: https://github.com/apache/shardingsphere/pull/14813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org