You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/08/01 00:54:18 UTC
Re: Review Request 68134: Avoided reviving on behalf of scheduler
after agent reconfiguration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68134/#review206713
-----------------------------------------------------------
PASS: Mesos patch 68134 was successfully built and tested.
Reviews applied: `['67962', '66820', '67776', '67809', '67812', '67813', '67814', '66843', '66855', '66856', '66870', '67878', '68085', '67187', '67823', '68048', '68134']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2016/mesos-review-68134
- Mesos Reviewbot Windows
On July 31, 2018, 6:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68134/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 6:57 p.m.)
>
>
> Review request for mesos, Benno Evers and Benjamin Mahler.
>
>
> Bugs: MESOS-9124
> https://issues.apache.org/jira/browse/MESOS-9124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When agent reconfiguration was enabled in Mesos, the allocator was
> also updated to remove all offer filters associated with an agent when
> that agent's attributes change. In addition, whenever filters for an
> agent are removed, the framework is revived for all roles that it is
> registered in.
>
> While this ensures that schedulers will have an opportunity to use
> resources on an agent after reconfiguration, modifying the scheduler's
> suppression may put the scheduler in an inconsistent state, where it
> believes it is suppressed in a particular role when it is not.
>
> This patch eliminates the suppression modification code, while
> keeping the code which removes a reconfigured agent's offer filters.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5
>
>
> Diff: https://reviews.apache.org/r/68134/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>