You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:54:30 UTC

[GitHub] [yunikorn-scheduler-interface] HuangTing-Yao opened a new pull request, #72: [YUNIKORN-1122]Move constants to scheduler interface

HuangTing-Yao opened a new pull request, #72:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/72

   ### What is this PR for?
   move shim and core constants to si repo, after this PR merged, will update the shim and core with latest si repo.
   Here is the list of shim and core:
   
   - Memory = "memory" & CPU = "vcore"
   core : `pkg/common/resources/resource.go`
   shim: `pkg/constants/constants.go`
   - NodeReadyAttribute = "ready"
   core : `pkg/scheduler/objects/node.go`
   shim: `pkg/constants/constants.go`
   - AppTagNamespaceResourceQuota = "namespace.resourcequota"
   core : `pkg/scheduler/objects/queue.go`
   shim : `pkg/constants/constants.go`
   - AppTagStateAwareDisable = "application.stateaware.disable"
   core : `pkg/scheduler/objects/application.go`
   shim : `pkg/constants/constants.go`
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1122
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-scheduler-interface] pbacsko closed pull request #72: [YUNIKORN-1122]Move constants to scheduler interface

Posted by GitBox <gi...@apache.org>.
pbacsko closed pull request #72: [YUNIKORN-1122]Move constants to scheduler interface
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org