You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/02/03 05:05:15 UTC
[GitHub] [iceberg] stevenzwu commented on a change in pull request #2159: AWS: Fail writes fast when S3OutputStream encountered error in async …
stevenzwu commented on a change in pull request #2159:
URL: https://github.com/apache/iceberg/pull/2159#discussion_r569133793
##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/S3OutputStreamTest.java
##########
@@ -133,6 +135,64 @@ public void testAbortMultipart() {
}
}
+ public void testFailWriteIntAfterAsyncError() throws Exception {
+ doThrow(new RuntimeException()).when(s3mock).uploadPart((UploadPartRequest) any(), (RequestBody) any());
Review comment:
good point. refactored the test to avoid duplicated code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org