You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/10 19:33:44 UTC

[GitHub] anirudhacharya commented on a change in pull request #12646: ONNX export: Fully connected operator w/o bias, ReduceSum, Square

anirudhacharya commented on a change in pull request #12646: ONNX export: Fully connected operator w/o bias, ReduceSum, Square
URL: https://github.com/apache/incubator-mxnet/pull/12646#discussion_r224212873
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -127,6 +127,14 @@ def convert_string_to_list(string_val):
 
     return result_list
 
+def convert_bool_to_int(attrs, attr_name):
 
 Review comment:
   you can call it `get_attribute_value` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services