[jira] [Updated] (SOLR-6759) ExpandComponent does not call finish() on DelegatingCollectors

["Simon Endele (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Endele updated SOLR-6759:
-------------------------------
    Attachment: ExpandComponent.java.patch

I'm not a Solr expert, but if I understand the code right, this can be fixed with a few lines.
Added a patch. Seems to work for us.

> ExpandComponent does not call finish() on DelegatingCollectors
> --------------------------------------------------------------
>
>                 Key: SOLR-6759
>                 URL: https://issues.apache.org/jira/browse/SOLR-6759
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Simon Endele
>         Attachments: ExpandComponent.java.patch
>
>
> We have a PostFilter for ACL filtering in action that has a similar structure as CollapsingQParserPlugin, i.e. it's DelegatingCollector gathers all documents and calls delegate.collect() for all docs finally in its finish() method.
> In contrast to CollapsingQParserPlugin our PostFilter is also called by the ExpandComponent (for purpose).
> But as the finish method is never called by the ExpandComponent, the "expand" section in the result is always empty.
> Tested with Solr 4.10.2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org