You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Naveen Gangam (JIRA)" <ji...@apache.org> on 2018/09/13 01:30:00 UTC

[jira] [Comment Edited] (THRIFT-4499) Remove Magic Number In TFIleTransport

    [ https://issues.apache.org/jira/browse/THRIFT-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612924#comment-16612924 ] 

Naveen Gangam edited comment on THRIFT-4499 at 9/13/18 1:29 AM:
----------------------------------------------------------------

[~tlipcon] Would you be able to review this patch? Thanks


was (Author: ngangam):
@toddlipcon Would you be able to review this patch? Thanks

> Remove Magic Number In TFIleTransport
> -------------------------------------
>
>                 Key: THRIFT-4499
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4499
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.11.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: THRIFT-4499.1.patch
>
>
> Here, the buffer is hard-coded to 8192 (which matches the default value on most JDK implementations). You may wish to remove this magic number and let the JDK decide the size.
> https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TFileTransport.java#L369



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)