You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/10/17 07:28:45 UTC
[GitHub] DickJC123 commented on issue #8313: Ci test randomness
DickJC123 commented on issue #8313: Ci test randomness
URL: https://github.com/apache/incubator-mxnet/pull/8313#issuecomment-337142795
Tests that are downstream from a test that previously set a seed will now see random data, where before they would not have. I also took out a global seed(42) call in test_operator_gpu.py, so some of those tests will see randomness for the first time.
It?s not too hard to make these tests robust. Takes me less than an hour per failure to understand the reason and correct it. With this PR, we?ll be able to reinvoke any failure and add instrumentation to understand it.
> On Oct 16, 2017, at 10:28 PM, Chris Olivier <no...@github.com> wrote:
>
> Does this change the random behavior of tests which don?t call one of your new functions?
>
> ?
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services