You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "combinatorist (via GitHub)" <gi...@apache.org> on 2023/10/25 18:34:45 UTC

Re: [PR] [SPARK-29615][SQL]Add a new insertInto method with byName parameter in DataFrameWriter. [spark]

combinatorist commented on PR #26275:
URL: https://github.com/apache/spark/pull/26275#issuecomment-1779837319

   It's not just verifying before insert that columns are aligned. Ideally, the method would allow you to insert _even when you already know the columns are not aligned_.
   
   You can easily get the same columns out of order when you use `withColumn` / `dropColumn` / `withColumnRenamed` type transformations.
   
   Also, if spark supports unionByName, then why not insertByName (or insert with byName option). If it's not useful at insert, should we simplify the methods for union as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org