You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2026/01/26 11:15:22 UTC

[PR] fix wrong format of backup/lifecycle resource [skywalking-banyandb-helm]

mrproliu opened a new pull request, #49:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/49

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix wrong format of backup/lifecycle/fodc resource [skywalking-banyandb-helm]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #49:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/49#discussion_r2729996351


##########
chart/values.yaml:
##########
@@ -977,10 +977,12 @@ cluster:
       resources:
         ## @param cluster.fodc.agent.resources.requests Resource requests for Agent
         requests:
-          memory: 256Mi
+          - key: memory
+            value: 256Mi
         ## @param cluster.fodc.agent.resources.limits Resource limits for Agent
         limits:
-          memory: 256Mi
+          - key: memory
+            value: 256Mi

Review Comment:
   `chart/values-lifecycle.yaml` still defines `cluster.fodc.agent.resources.requests/limits` as a map (e.g., `memory: 256Mi`). With the updated templates expecting a list of `{key,value}` objects, using `-f chart/values-lifecycle.yaml` will cause Helm rendering errors (attempting to access `$request.key` on a map value). Update `chart/values-lifecycle.yaml` to the same list format used in `chart/values.yaml` for FODC agent (and proxy, if applicable).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix wrong format of backup/lifecycle/fodc resource [skywalking-banyandb-helm]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #49:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix wrong format of backup/lifecycle resource [skywalking-banyandb-helm]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #49:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/49#discussion_r2727240371


##########
test/e2e/values.lifecycle.yaml:
##########
@@ -193,12 +193,34 @@ cluster:
           enabled: true
           progressFile: "/tmp/stream/lifecycle/progress.json"
           reportDir: "/tmp/stream/lifecycle/reports"
+          resources:

Review Comment:
   `lifecycleSidecar.resources` is being set using the list-of-`{key,value}` format (matching `cluster.data.nodeTemplate.resources`), but the chart renders sidecar resources via `toYaml` (see `chart/templates/cluster_data_statefulset.yaml`), which expects standard Kubernetes `resources` maps (e.g., `requests.cpu: 200m`). With the current list format, the rendered StatefulSet will have an invalid `resources` shape and may fail to apply. Please change this to the standard map form under `requests`/`limits` (cpu/memory as keys).



##########
test/e2e/values.lifecycle.yaml:
##########
@@ -193,12 +193,34 @@ cluster:
           enabled: true
           progressFile: "/tmp/stream/lifecycle/progress.json"
           reportDir: "/tmp/stream/lifecycle/reports"
+          resources:
+            requests:
+              - key: cpu
+                value: 200m
+              - key: memory
+                value: 128Mi
+            limits:
+              - key: cpu
+                value: 500m
+              - key: memory
+                value: 512Mi
       warm:
         lifecycleSidecar:
           schedule: "@daily"
           enabled: true
           progressFile: "/tmp/stream/lifecycle/progress.json"
           reportDir: "/tmp/stream/lifecycle/reports"
+          resources:

Review Comment:
   Same issue as hot role: `lifecycleSidecar.resources` uses a list-of-`{key,value}` entries, but the chart templates render sidecar `resources` via `toYaml`, which requires the standard Kubernetes map structure (`requests.cpu`, `limits.memory`, etc.). Update this block to a map-based `resources` definition so the generated manifest is valid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix wrong format of backup/lifecycle/fodc resource [skywalking-banyandb-helm]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on code in PR #49:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/49#discussion_r2729845506


##########
chart/values.yaml:
##########
@@ -976,11 +976,9 @@ cluster:
       containerSecurityContext: {}
       resources:
         ## @param cluster.fodc.agent.resources.requests Resource requests for Agent
-        requests:

Review Comment:
   Restore the default memory setting for fodc agent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org