You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/23 22:10:42 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
pkarashchenko opened a new pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320
## Summary
Add HSMCI0 boot mount configuration option
## Impact
SAMv7 based boards
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once a review has been done the author can merge it?
2) If only one company does a review, that can lead to undo influence as noted as the ["The Enemies"](https://github.com/apache/incubator-nuttx/blob/master/INVIOLABLES.md)
Focus on the values of the organization, not the values of the Open Source project. Need to support both.
I would suggest we change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1019760127
I saw cases like this https://github.com/apache/incubator-nuttx/pull/5284, so was thinking that it is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020459911
@davids5 I think it could be voted since it was defined by others. If you search here in the github history you will find the commit from me that I unintentionally merged and others started to complain about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once a review has been done the author can merge it?
2) If only one company does a review, that can lead to undo influence as noted as the ["The Enemies"](https://github.com/apache/incubator-nuttx/blob/master/INVIOLABLES.md)
Focus on the values of the organization, not the values of the Open Source project. Need to support both.
I would suggest we change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1019654052
@acassis I think @pkarashchenko merge it because you have approved the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1019758937
@acassis sorry for that. I will follow the agreement. I merged changes because you approved it and CI was complete and change is relatively trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once a review has been done the author can merge it?
2) If only one company does a review, that can lead to undo influence as noted as the ["The Enemies"] (https://github.com/apache/incubator-nuttx/blob/master/INVIOLABLES.md)
Focus on the values of the organization, not the values of the Open Source project. Need to support both.
I would suggest we change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020459911
@davids5 I think it could be voted since it was defined by others. If you search here in the github history you will find the commit from me that I unintentionally merged and others started to complain about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020056116
Don't worry @pkarashchenko I imagined you didn't know about it. Yes, sometimes we it by mistake, for example when you are doing the PR from github interface and think you are click on submit the PR to master project, but you are in the next step to merge it on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1019614771
@pkarashchenko I noticed you are merging your own PR, we have an agreement to we cannot merge our own PR, although we can merge PR from colleague eve from the same company.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1019654052
@acassis I think @pkarashchenko merge it because you have approve the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5320: boards/arm/samv7/common: add HSMCI0 boot mount configuration option
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5320:
URL: https://github.com/apache/incubator-nuttx/pull/5320#issuecomment-1020379240
@acassis - Two thoughts here:
1 ) Given the geographical and time differences should we consider that once a review has been done the author can merge it?
2) If only one company does a review, that can lead to undo influence as noted as the ["The Enemies"] (https://github.com/apache/incubator-nuttx/blob/master/INVIOLABLES.md)
Focus on the values of the organization, not the values of the Open Source project. Need to support both.
I would suggest we change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org