You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2020/04/27 16:12:03 UTC

Proposal to include fix for GEODE-8020 in support/1.12

commit ec8db54ad7f342542762beb8f3e912dff44e3a53 (HEAD -> develop, origin/develop)

Author: Bruce Schuchardt <bs...@pivotal.io>

Date:   Mon Apr 27 09:07:16 2020 -0700

 

    GEODE-8020: buffer corruption in SSL communications (#4994)

 

    revert change in GEODE-6661 that made NioSslEngine use a direct buffer.

    This class is not designed to share its buffer with a pool in

    BufferPool.  Connection is also modified to use a heap buffer for

    reading encrypted SSL packets for consistency.  New tests ensure that

    these buffers are the correct type when using SSL or plain sockets.

Re: Proposal to include fix for GEODE-8020 in support/1.12

Posted by Bruce Schuchardt <bs...@pivotal.io>.
Thanks - this has been merged to the support branch
    
    > On Apr 27, 2020, at 9:12 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
    > 
    > commit ec8db54ad7f342542762beb8f3e912dff44e3a53 (HEAD -> develop, origin/develop)
    > 
    > Author: Bruce Schuchardt <bs...@pivotal.io>
    > 
    > Date:   Mon Apr 27 09:07:16 2020 -0700
    > 
    > 
    > 
    >     GEODE-8020: buffer corruption in SSL communications (#4994)
    > 
    > 
    > 
    >     revert change in GEODE-6661 that made NioSslEngine use a direct buffer.
    > 
    >     This class is not designed to share its buffer with a pool in
    > 
    >     BufferPool.  Connection is also modified to use a heap buffer for
    > 
    >     reading encrypted SSL packets for consistency.  New tests ensure that
    > 
    >     these buffers are the correct type when using SSL or plain sockets.
    >

Re: Proposal to include fix for GEODE-8020 in support/1.12

Posted by Owen Nichols <on...@pivotal.io>.
+1

> On Apr 27, 2020, at 9:12 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
> 
> commit ec8db54ad7f342542762beb8f3e912dff44e3a53 (HEAD -> develop, origin/develop)
> 
> Author: Bruce Schuchardt <bs...@pivotal.io>
> 
> Date:   Mon Apr 27 09:07:16 2020 -0700
> 
> 
> 
>     GEODE-8020: buffer corruption in SSL communications (#4994)
> 
> 
> 
>     revert change in GEODE-6661 that made NioSslEngine use a direct buffer.
> 
>     This class is not designed to share its buffer with a pool in
> 
>     BufferPool.  Connection is also modified to use a heap buffer for
> 
>     reading encrypted SSL packets for consistency.  New tests ensure that
> 
>     these buffers are the correct type when using SSL or plain sockets.
>

Re: Proposal to include fix for GEODE-8020 in support/1.12

Posted by Anthony Baker <ab...@pivotal.io>.
+1

> On Apr 27, 2020, at 9:14 AM, Kirk Lund <kl...@apache.org> wrote:
> 
> +1
> 
> On Mon, Apr 27, 2020 at 9:12 AM Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> 
>> commit ec8db54ad7f342542762beb8f3e912dff44e3a53 (HEAD -> develop,
>> origin/develop)
>> 
>> Author: Bruce Schuchardt <bs...@pivotal.io>
>> 
>> Date:   Mon Apr 27 09:07:16 2020 -0700
>> 
>> 
>> 
>>    GEODE-8020: buffer corruption in SSL communications (#4994)
>> 
>> 
>> 
>>    revert change in GEODE-6661 that made NioSslEngine use a direct buffer.
>> 
>>    This class is not designed to share its buffer with a pool in
>> 
>>    BufferPool.  Connection is also modified to use a heap buffer for
>> 
>>    reading encrypted SSL packets for consistency.  New tests ensure that
>> 
>>    these buffers are the correct type when using SSL or plain sockets.
>> 
>>

Re: Proposal to include fix for GEODE-8020 in support/1.12

Posted by Kirk Lund <kl...@apache.org>.
+1

On Mon, Apr 27, 2020 at 9:12 AM Bruce Schuchardt <bs...@pivotal.io>
wrote:

> commit ec8db54ad7f342542762beb8f3e912dff44e3a53 (HEAD -> develop,
> origin/develop)
>
> Author: Bruce Schuchardt <bs...@pivotal.io>
>
> Date:   Mon Apr 27 09:07:16 2020 -0700
>
>
>
>     GEODE-8020: buffer corruption in SSL communications (#4994)
>
>
>
>     revert change in GEODE-6661 that made NioSslEngine use a direct buffer.
>
>     This class is not designed to share its buffer with a pool in
>
>     BufferPool.  Connection is also modified to use a heap buffer for
>
>     reading encrypted SSL packets for consistency.  New tests ensure that
>
>     these buffers are the correct type when using SSL or plain sockets.
>
>