You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2023/12/12 14:02:14 UTC

[PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

mrproliu opened a new pull request, #72:
URL: https://github.com/apache/skywalking-goapi/pull/72

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1853018430

   Following the [release policy on the official website](https://go.dev/doc/devel/release#policy), It looks like `go1.16` has not been supported. For now, the `go1.20` is still supported. But this is an API package, and still many project dependencies in the go API project, such as [Go Agent](https://github.com/apache/skywalking-go), [Rover](https://github.com/apache/skywalking-rover), if this project upgrade, I think they should also need to be updated. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1852202315

   Is go 1.6 still in maintenance mode by Google?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1853083700

   Let bump up version to minimal Google supported go version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1853071313

   > Following the [release policy on the official website](https://go.dev/doc/devel/release#policy), It looks like `go1.16` has not been supported. For now, the `go1.20` is still supported. But this is an API package, and still many project dependencies in the go API project, such as [Go Agent](https://github.com/apache/skywalking-go), [Rover](https://github.com/apache/skywalking-rover), if this project upgrade, I think they should also need to be updated. 
   
   We should follow what go officially support. Otherwise, we will face no CVE support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1852105539

   Anything wrong about the build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1852178443

   I have downgraded my Go version to 1.16, and then the CI fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Sync data collect protocol for eBPF access log [skywalking-goapi]

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #72:
URL: https://github.com/apache/skywalking-goapi/pull/72#issuecomment-1853021674

   I recommend we still use `go1.16` in this project, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org